[00:00:30] *** Quits: vishwin60 (~clc-mac@wikimedia/O) (Quit: ChatZilla 0.9.92 [Firefox 38.4.0/20151027170520])
[00:04:42] *** Quits: smudkavi (~smudkavi@CPE00fc8d207be1-CM00fc8d207be0.cpe.net.cable.rogers.com) (Quit: Woops, the client slept)
[01:38:15] *** Joins: vishwin_ (~alliek@wikimedia/O)
[06:10:59] *** Quits: SamuelKelemen (442396c9@gateway/web/cgi-irc/kiwiirc.com/ip.68.35.150.201) (Ping timeout: 264 seconds)
[07:43:31] *** Joins: smudkavi (~smudkavi@CPE00fc8d207be1-CM00fc8d207be0.cpe.net.cable.rogers.com)
[09:21:20] *** Quits: robbyoconnor (~wakawaka@guifications/user/r0bby) (Ping timeout: 245 seconds)
[09:29:56] *** Quits: vishwin_ (~alliek@wikimedia/O) (Ping timeout: 240 seconds)
[09:31:35] *** Joins: vishwin_ (~alliek@wikimedia/O)
[12:53:23] *** Quits: smudkavi (~smudkavi@CPE00fc8d207be1-CM00fc8d207be0.cpe.net.cable.rogers.com) (Quit: Woops, the client slept)
[14:42:17] *** Joins: robbyoconnor (~wakawaka@guifications/user/r0bby)
[14:57:10] <iangcarroll> wow gsingh93
[14:57:14] <iangcarroll> no 2FA on github
[14:57:16] <iangcarroll> weak
[15:01:17] <iangcarroll> also, need you to review https://github.com/wearehx/voting/pull/24 when you have a chance
[15:01:24] <yossarian-bot> Title: Correct Facebook namespacing. by iangcarroll · Pull Request #24 · wearehx/voting · GitHub
[15:01:26] <iangcarroll> i believe this was the issue breaking the group member whitelist
[15:43:57] *** Joins: smudkavi (~smudkavi@wn-campus-nat-129-97-124-137.dynamic.uwaterloo.ca)
[16:12:15] <gsingh93> iangcarroll: i've been debating it for a long time
[16:12:46] <gsingh93> i don't think the 2fa is worth it for github
[16:12:51] <gsingh93> i have all my repos backed up
[16:13:06] <gsingh93> it's not like it's my gmail or bank
[16:13:35] <iangcarroll> I mean, you're an admin of the Hackers org :p
[16:14:04] <iangcarroll> plus if anyone relies on your repos for code bad things could be inserted
[16:14:30] <gsingh93> yea, being an admin of an org is a new thing for me
[16:14:35] <gsingh93> so previously i didn't care
[16:14:47] <gsingh93> for two, i mean, there's already backdoors in all my projects
[16:14:52] <gsingh93> so nothing new there
[16:15:38] <iangcarroll> lol
[16:15:44] <iangcarroll> gg
[16:15:47] <cydrobolt> oh lol
[16:15:53] <cydrobolt> I use 2fa now
[16:16:05] <cydrobolt> If you use your SSH key you won't need to get a personal token each time
[16:17:18] <iangcarroll> oh, I only fixed one of the namespace errors
[16:17:20] <iangcarroll> :$
[16:20:57] <iangcarroll> found another bug too
[16:20:59] <iangcarroll> https://github.com/wearehx/voting/pull/25
[16:21:00] <yossarian-bot> Title: Second namespace fix and minor refactoring by iangcarroll · Pull Request #25 · wearehx/voting · GitHub
[16:45:33] <gsingh93> stop writing buggy code ian
[16:49:36] <vishwin> lol
[17:05:51] <iangcarroll> :(
[17:08:18] <iangcarroll> also i'm fixing the fuckery that datacontroller is
[17:40:03] *** Joins: sivoais (~zaki@unaffiliated/sivoais)
[17:41:47] *** Quits: smudkavi (~smudkavi@wn-campus-nat-129-97-124-137.dynamic.uwaterloo.ca) (Quit: Woops, the client slept)
[17:57:16] <cydrobolt> iangcarroll, what is this in
[17:57:37] <iangcarroll> in being language or what project?
[17:57:42] <cydrobolt> what lang
[17:57:44] <iangcarroll> PHP
[17:58:13] <iangcarroll> 7, if it matters
[18:10:46] <iangcarroll> i'm redoing the candidate list because I don't believe `shuffle` is secure
[18:10:59] <gsingh93> lol
[18:11:00] <iangcarroll> but now I'm rolling my own code, so you might need to review this carefully
[18:11:01] <gsingh93> "secure"
[18:11:10] <gsingh93> how could someone exploit that?
[18:11:17] <iangcarroll> lol, not exploitable
[18:11:19] <gsingh93> exactly
[18:11:29] <iangcarroll> but if the RNG is biased towards a candidate
[18:11:31] <iangcarroll> it seems unfair
[18:12:41] <gsingh93> oh it's biased
[18:12:46] <gsingh93> i just thought it was predictable
[18:13:19] <iangcarroll> i'm looking into it atm
[18:15:12] <iangcarroll> hm
[18:15:18] <iangcarroll> is rand() biased or just predictable?
[18:15:40] <iangcarroll> the comments seem to show a bias
[18:16:25] <gsingh93> i was pretty sure it was just predictable
[18:16:31] <gsingh93> it uses that linear shift thingy
[18:16:34] <gsingh93> forget the name
[18:16:59] <iangcarroll> the comments say it's only producing numbers that are a multiple of 3
[18:17:02] <iangcarroll> but I can't reproduce that
[18:17:49] <gsingh93> wtf
[18:17:52] <gsingh93> comments where?
[18:18:18] <iangcarroll> on the PHP article about it
[18:18:23] <iangcarroll> s/article/doc
[18:18:23] <yossarian-bot> iangcarroll probably meant: on the PHP doc about it
[18:18:53] <iangcarroll> might've been fixed
[18:24:15] <iangcarroll> just gonna include it in the PR for now
[18:24:26] <iangcarroll> not a bad idea to use a CSPRNG, unless I manage to bork it
[18:42:22] <iangcarroll> https://github.com/wearehx/voting/blob/iangcarroll-patch-2/app/Http/Controllers/VoteController.php#L68
[18:42:23] <yossarian-bot> Title: voting/VoteController.php at iangcarroll-patch-2 · wearehx/voting · GitHub
[19:53:22] *** Quits: vishwin_ (~alliek@wikimedia/O) (Ping timeout: 250 seconds)
[19:54:24] *** Joins: vishwin_ (~alliek@wikimedia/O)
[19:54:34] *** Joins: smudkavi (~smudkavi@208.72.125.2)
[20:40:35] *** Quits: vishwin_ (~alliek@wikimedia/O) (Ping timeout: 240 seconds)
[20:41:57] *** Joins: vishwin_ (~alliek@wikimedia/O)
[21:41:57] *** Quits: smudkavi (~smudkavi@208.72.125.2) (Quit: Woops, the client slept)
[22:06:03] *** Joins: smudkavi (~smudkavi@CPE00fc8d207be1-CM00fc8d207be0.cpe.net.cable.rogers.com)
[23:18:18] *** Quits: robbyoconnor (~wakawaka@guifications/user/r0bby) (Excess Flood)
[23:18:47] *** Joins: robbyoconnor (~wakawaka@guifications/user/r0bby)