[01:02:38] *** Joins: r0bby_ (~wakawaka@guifications/user/r0bby)
[01:02:40] *** Quits: robbyoconnor (~wakawaka@guifications/user/r0bby) (Ping timeout: 244 seconds)
[02:11:34] <iangcarroll> gsingh93: can you delete the term
[02:13:19] <iangcarroll> and then create the next one with `php artisan term:create 2016 04 18`
[02:23:57] <iangcarroll> then run `php artisan notify "https://hackers-voting.herokuapp.com" "Nominations for the next term are now open. You can nominate three people to run for admin."` or something
[02:23:58] <yossarian-bot> Title: Unknown
[02:24:05] <iangcarroll> it's 2AM so idk how to word
[02:49:54] <gsingh93> sorry, just got home
[02:51:52] <gsingh93> iangcarroll: nextTerm() -> null
[02:52:18] <iangcarroll> App\Term::find(3) instead
[02:52:27] <iangcarroll> App\Term::find(3)->delete()
[02:54:40] <gsingh93> iangcarroll: before i notify
[02:54:52] <gsingh93> should we change the number of nominations you need?
[02:54:58] <gsingh93> like that meta post suggested?
[02:55:07] <gsingh93> we didn't make a PR or anything
[02:55:20] <gsingh93> i.e., you just need to mark your self as running
[02:55:45] <iangcarroll> i don't oppose changing it to one
[02:55:52] <gsingh93> kk
[02:55:57] <gsingh93> i'll go ahead with it then
[02:56:10] <iangcarroll> kk
[02:56:25] <gsingh93> wait
[02:56:27] <gsingh93> this isn't a variable
[02:56:29] <gsingh93> is it
[02:56:31] <gsingh93> :(
[02:57:51] <iangcarroll> oh
[02:57:57] <gsingh93> i can change this to >= 1: https://github.com/wearehx/voting/blob/master/app/Http/Controllers/NominationController.php#L37
[02:57:57] <yossarian-bot> Title: voting/NominationController.php at master · wearehx/voting · GitHub
[02:58:15] <iangcarroll> yeah
[02:58:38] <gsingh93> and there's one more spot, right?
[03:00:55] <iangcarroll> ye
[03:01:20] <iangcarroll> uhh
[03:01:24] <iangcarroll> just found a vuln...
[03:01:43] <gsingh93> https://github.com/wearehx/voting/blob/master/app/User.php#L71
[03:01:43] <yossarian-bot> Title: voting/User.php at master · wearehx/voting · GitHub
[03:01:45] <iangcarroll> the POST to mark yourself as running doesn't check this
[03:02:12] <iangcarroll> but yeah, that's where it should be checking
[03:02:24] <gsingh93> lol
[03:02:26] <gsingh93> yea
[03:02:30] <gsingh93> i didn't see it being used
[03:02:57] <gsingh93> just need an `if (Auth::user()->canRun())` here, right: https://github.com/wearehx/voting/blob/master/app/User.php#L71
[03:02:57] <yossarian-bot> Title: voting/User.php at master · wearehx/voting · GitHub
[03:03:32] <iangcarroll> just committed
[03:05:40] <gsingh93> what's the command to set an env?
[03:05:55] <iangcarroll> heroku config:set KEY=VALUE
[03:09:09] <gsingh93> iangcarroll: https://github.com/wearehx/voting/commit/de327058dbffb969aa545504fbfb2fd4795d0054
[03:09:09] <yossarian-bot> Title: Added an env for MIN_NOMINATIONS · wearehx/voting@de32705 · GitHub
[03:09:11] <gsingh93> look good?
[03:09:20] <iangcarroll> ye, just saw
[03:09:29] <gsingh93> i'm going to nominate you
[03:09:33] <gsingh93> just check if it works
[03:09:49] <iangcarroll> kk
[03:09:56] <iangcarroll> make sure it deploys
[03:09:56] <gsingh93> kk
[03:10:05] <gsingh93> let me know if you can run now
[03:10:07] <gsingh93> with one nominations
[03:10:15] <iangcarroll> i can
[03:10:24] <gsingh93> cool
[03:10:27] <iangcarroll> gr8
[03:10:30] <iangcarroll> everything seems to be functional
[03:10:33] <gsingh93> going to send a notification now
[03:10:38] <iangcarroll> good luck
[03:10:44] <iangcarroll> haven't tested it yet so
[03:10:47] <iangcarroll> lol
[03:12:21] <gsingh93> looks like you can't pass arguments to artisan like that
[03:12:42] <iangcarroll> might have to escape it then
[03:12:59] <iangcarroll> with \'s with spaces instead of quotes
[03:16:25] <gsingh93> so
[03:16:36] <gsingh93> i'm normally fine with testing in prod
[03:16:43] <gsingh93> but i don't want to do that with notifications
[03:16:45] <gsingh93> :P
[03:17:24] <iangcarroll> well
[03:17:32] <iangcarroll> it either fails completely or works completely
[03:17:36] <iangcarroll> probably
[03:17:57] <gsingh93> I'm just worried something will go wrong and they'll get like the first word of the message
[03:18:01] <gsingh93> if i escape it wrong
[03:18:17] <iangcarroll> let me test that
[03:18:54] <gsingh93> heroku run php artisan notify "https://hackers-voting.herokuapp.com" Nominations\ for\ the\ next\ term\ are\ now\ open.\ You\ only\ need\ one\ nomiation\ to\ run.\ Nominating\ yourself\ is\ allowed.
[03:18:54] <yossarian-bot> Title: Unknown
[03:19:01] <iangcarroll> php artisan notify https://ian.sh "A B C"
[03:19:02] <gsingh93> should i try that?
[03:19:03] <yossarian-bot> Title: ian.sh
[03:19:04] <iangcarroll> this works for me
[03:19:06] <iangcarroll> with quotes
[03:19:08] <gsingh93> well
[03:19:12] <gsingh93> i'm using heroku run
[03:19:16] <iangcarroll> oh
[03:20:23] <iangcarroll> how about heroku run "php artisan notify https://hackers-voting.herokuapp.com \"Nominations for the next term are now open. You only need one nomiation to run. Nominating yourself is allowed.\""
[03:20:24] <yossarian-bot> Title: Unknown
[03:20:49] <iangcarroll> either will probably work
[03:20:51] <iangcarroll> i'll test
[03:21:24] <iangcarroll> both work for me
[03:21:32] <iangcarroll> and by work I mean the escaping is correct
[03:22:36] <gsingh93> neither work for me
[03:22:46] <gsingh93> is your other app not on heroku?
[03:23:23] <iangcarroll> what error do you get?
[03:23:38] <iangcarroll> i ran it through bash -c to simulate passing it as an argument
[03:25:01] <gsingh93> Running `php artisan notify https://hackers-voting.herokuapp.com Nominations for the next term are now open. You only need one nomination to run. Nominating yourself is allowed.`
[03:25:01] <yossarian-bot> Title: Unknown
[03:25:04] <gsingh93> "Too many arguments"
[03:25:16] <gsingh93> oh
[03:25:18] <gsingh93> wait
[03:25:23] <gsingh93> i didn't escape the quotes right
[03:25:29] <iangcarroll> yeah
[03:25:38] <iangcarroll> i.e. /bin/bash -c "php artisan notify https://hackers-voting.herokuapp.com \"Nominations for the next term are now open. You only need one nomiation to run. Nominating yourself is allowed.\""
[03:25:39] <yossarian-bot> Title: Unknown
[03:26:12] <gsingh93> Fatal error: Class 'Facebook\FacebookSession' not found
[03:26:37] <iangcarroll> sigh
[03:28:50] <iangcarroll> pushed a fix
[03:29:21] <gsingh93> Fatal error: Call to undefined method Facebook\FacebookRequest::execute()
[03:29:44] * iangcarroll sighs again
[03:31:08] <iangcarroll> are the PHP code examples out of date in the docs?
[03:31:29] <gsingh93> idk...
[03:31:38] <gsingh93> shouldn't be
[03:33:16] <iangcarroll> well
[03:33:19] <iangcarroll> attempt v3 pushed
[03:35:13] <gsingh93> [Facebook\Exceptions\FacebookResponseException]
[03:35:16] <gsingh93>   Error validating access token: Session has expired on Thursday, 03-Mar-16 15:51:27 PST. The current time is Monday, 04-Apr-16 00:34:40 PDT.
[03:35:24] <gsingh93> what session?
[03:36:26] <iangcarroll> hm
[03:36:47] <iangcarroll> we might have to renew it
[03:39:54] <iangcarroll> you can't be serious
[03:40:06] <iangcarroll> apparently socialite doesn't store the refresh token
[03:40:25] <iangcarroll> so I guess we can only notify people who have a non-expired token
[03:42:11] <iangcarroll> it catches that exception now
[03:46:55] <gsingh93> no error this time
[03:47:03] <gsingh93> but i didn't get a notification
[03:47:54] <iangcarroll> nor did I
[03:47:58] <iangcarroll> and my token should be updated
[03:48:24] <iangcarroll> i am probably catching another exception in the process
[03:49:16] <iangcarroll> it prints the exception now
[03:50:10] <gsingh93> to the heroku logs?
[03:50:25] <gsingh93> i hope no one got a notification last time
[03:50:37] <gsingh93> because now they'll get two notifications
[03:51:38] <iangcarroll> doesn't seem possible
[03:51:41] <iangcarroll> and yea
[03:51:43] <iangcarroll> stdout
[03:53:34] <gsingh93> lol
[03:53:39] <gsingh93> Undefined property: Facebook\Exceptions\FacebookResponseException::$getMessage
[03:55:15] <iangcarroll> wat
[03:56:32] <iangcarroll> oh
[03:56:33] <iangcarroll> fixeds
[03:56:36] <iangcarroll> s/s/
[03:56:36] <yossarian-bot> iangcarroll probably meant: fixed
[03:57:38] <gsingh93> Caught exception Error validating access token: Session has expired on Thursday, 03-Mar-16 15:51:27 PST. The current time is Monday, 04-Apr-16 00:57:02 PDT..
[03:57:40] <gsingh93> Caught exception Error validating access token: The session has been invalidated because the user has changed the password..
[03:57:54] <gsingh93> Caught exception Error validating access token: Session does not match current stored session. This may be because the user changed the password since the time the session was created or Facebook has changed the session for security reasons..
[03:58:13] <gsingh93> Caught exception Error validating access token: Sessions for the user  are not allowed because the user is not a confirmed user..
[03:58:28] <gsingh93> Caught exception (#200) Only web canvas apps can send app notifications.
[03:58:41] <gsingh93> those are the unique exceptions
[03:59:13] <iangcarroll> the last one seems like a legit one
[04:00:23] <iangcarroll> ok, we're now a web canvas app
[04:00:23] <iangcarroll> lol
[04:03:33] <gsingh93> Caught exception (#15) This method must be called with an app access_token..
[04:04:09] <gsingh93> i don't understand how we have users that haven't authorized the application
[04:04:19] <gsingh93> Caught exception Error validating access token: The user has not authorized application 892158150899334..
[04:04:52] <iangcarroll> updated
[04:05:01] <iangcarroll> idk how that last one would happen
[04:05:11] <iangcarroll> probably someone deauthing
[04:06:15] <gsingh93> "You must provide an access token"
[04:06:20] <gsingh93> uncaught exception this time
[04:06:53] <iangcarroll> huh, it's supposed to be pulling from FACEBOOK_APP_ID
[04:07:00] <iangcarroll> slash FACEBOOK_APP_SECRET
[04:07:57] <iangcarroll> are those env variables set?
[04:08:02] <iangcarroll> `heroku config` dumps them
[04:08:53] <gsingh93> both are set
[04:10:31] <gsingh93> you removed $user->token and this started happening
[04:12:12] <iangcarroll> cuz I wanted it to use the app access token
[04:13:21] <gsingh93> if you want, you can just post in the group that nominations have started and then work on this tomorrow
[04:13:39] <iangcarroll> gonna try a fix and then that
[04:15:29] <iangcarroll> pushed a "fix"
[04:17:24] <gsingh93> nice
[04:17:31] <gsingh93> got a notification
[04:17:46] <gsingh93> but it takes you to a page that says "something went wrong"
[04:18:05] <gsingh93> like 7 of these:
[04:18:07] <gsingh93> Caught exception (#200) Cannot send notifications to a user who has not installed the app.
[04:18:23] <gsingh93> one of these:
[04:18:25] <gsingh93> Caught exception Unsupported post request. Please read the Graph API documentation at https://developers.facebook.com/docs/graph-api.
[04:18:25] <yossarian-bot> Title: Unknown
[04:18:27] <gsingh93> no other exceptions
[04:18:32] <iangcarroll> well
[04:18:45] <iangcarroll> it appears the URL got overrided to our canvas URL
[04:19:15] <gsingh93> might as well put something on that canvas page
[04:19:25] <iangcarroll> yeah
[04:19:33] <iangcarroll> the problem is that fb makes a POST request to it first
[04:19:42] <iangcarroll> just added a handler for it
[04:30:15] <iangcarroll> can you see the exception getting thrown in the heroku logs?
[04:34:10] <gsingh93> no exceptions
[05:27:03] *** Quits: wolfcore (~wolfcore@unaffiliated/wolfcore) (Ping timeout: 240 seconds)
[05:36:49] *** Joins: wolfcore (~wolfcore@unaffiliated/wolfcore)
[10:57:02] *** Joins: majora (~majora@205.204.23.189)
[10:57:02] *** ChanServ sets mode: +v majora
[10:57:07] <majora> make computers blow up again
[11:37:53] *** Quits: majora (~majora@205.204.23.189) (Quit: Leaving)
[15:10:40] *** Joins: lablayers (uid55894@gateway/web/irccloud.com/x-ephfdlokayafcayj)
[20:48:04] *** Quits: r0bby_ (~wakawaka@guifications/user/r0bby) (Read error: Connection reset by peer)
[20:48:26] *** Joins: r0bby_ (~wakawaka@guifications/user/r0bby)